MArcomage

Since the change made a few minutes ago, I am unable to accept a game challenge. Every one of my decks is reporting "No such deck" as I choose it. I'm going to try making a change to one of them and see if that validates it.

No good. It's still telling me "No such deck!" in red near the top whenever I select a deck to accept the challenge. It even happens when choosing Random.

happened to me as well

Screenshots please. I accepted a challenge without any problems just right now.

http://www.fmroses.us/personal/DPsycho/nosuch.jpg

there's another player who said there's a problem with accepting my challenge, maybe it's my fault since it occured to DPsycho on my challenge as well

Hm, yeah, I just accepted a challenge from another player without any problems. Odd.

i'll try logging out and coming back again

Yeah im facing this bug now too.
Cant accept the game 'cause it says my decks dont exist.

I've done some research on this bug, but I wasn't able to replicate it. According to my analysis this bug is probably not deck related. I think the bug is related to challenges themselves.

Let me describe the bug again:

Player1 challenges Player2 and Player2 reports that he can't accept the challenge from Player1 ("No such deck" error message).

Anyone who is in the position of Player1 please try to resend the challenge and ask Player2 to try to accept the challenge once again. Please report if he was able to accept the challenge or not.

I blame Lord Ornlu! I'm having the same problem, and it happens to be his challenge. I was able to accept challenges from other people since the update without having this problem.

I've challenged Chemo and he can't accept my challenge becouse this bug. I've used the random deck option, maybe the bug is related to that.

Edit:
I rechallenged Chemo without the "random deck" option, but still he can't accept.

Edit: now even I can't accept a challenge (from ?????)

everyone blames me *sniff*

it's probably my fault though :O

Ok guys, I found the bug. It seem every player that has special characters in names will produce challenges that cannot be accepted. So for example Lord Ornlu or Fithz Hood has a empty space in their name, so you can't accept their challenges. I will fix it ASAP.

I suppose this bug does not affect the new host mode, 'couse I get my hosted challenges all accepted.

This effects only challenges used in the classic system of creating new games. Fixed in https://netvor.sk/trac/arcomage/changeset/724 (changes should be applied soon)

Fix applied. Sorry for the delay.

Im curious where this came from all of a sudden. Before the Host feature this didn't happen. While implementing that, minor adaptation for the classic challenge method was needed, which caused the mal function?
(Not my field)

Not so easy task to explain but I will try. The bug was created here https://netvor.sk/trac/arcomage/changeset/710 by me.

I changed the system how the games are identified. Until then they were identified by names of both players. The new system would identify them by game id (identification number) instead.

When you accept a challenge the system needs to know who your opponent is. By changing the system I had to change the way how this information is obtained.

Since player names can contain some special characters that could endanger the application functionality, we use some encoding functions, when working with player names. For example empty space is translated to "%20".

So, instead of proper escaping, I provided the opponent name directly to the system. When testing, I didn't notice anything strange, because my test users don't have such characters in their names. This is why every player, that has only alphanumerical characters in name, had no problem, but if you had at least one special character in name, your challenge could not be accepted.

The reason why the system was providing us with weird error message "No such deck" is simple. It uses opponent name to identify the place where your deck name is located. Without it, he failed to load your deck.

I plan to simplify the process, since I don't think you need one deck selector for every incoming challenge. Hosted games have only one deck selector, which can be used for any game to join.