MArcomage

So, uh, I can't be the only one affected/bothered by this, can I? When you press the "quote" button next to a post with a URL, the url tags in the quoted text are gutted of the original url.

I don't remember this being an issue when we rolled out the phpBB stuff (I think...).

Edit: Yup, just fired up a copy of the site circa my phpBB patch. Url quoting looks fine, so I guess I'm off the hook personally.

Yes, it seems something is wrong with the BBcode. I'll look into it.

Mojko wrote:
Yes, it seems something is wrong with the BBcode. I'll look into it.

If you do figure out what's wrong, I'll be curious to know. I've been looking at the code, and the problem eludes me. My best guess is that it's something in the XSLT template (though I couldn't find anything suspect in the diff...). I wish I could get the current code running on WAMP, but I'm running into problems for unknown reasons (I probably went through the exact same thing last time, and have since forgotten...).

By the way, while poking through the code, I noticed that the quoting system is (I believe) broken for names with closing square braces. Not a big deal, but it's something. I've always thought marco was far too liberal when it comes to what characters people can put in their usernames :P

Allowing arbitrary names was something we did at the very beginning, since it ensures we don't get lazy and use encoding where needed. And the fact that the names are supposed to work everywhere does not allow any blind spots.

Unfortunately, the bbcode parser is third-party code and I have no clue how it works. I would assume that it does not have any form of "bb escaping", which would be required for the "quote" feature to work on names that contain a ]. Not sure how to solve this right now.

The parser doesn't seem to support escaping of braces, so it would require some modification of the parser's functionality.

I was unable to replicate the situation when quoting failed. Characters "[" and "]" confuse the BBcode parser a bit, but they doesn't seem to destroy URLs. If you happen to experience this bug, please direct link the post you quoted.

dindon wrote:
So, uh, I can't be the only one affected/bothered by this, can I? When you press the "quote" button next to a post with a [url=]URL[/url], the url tags in the quoted text are gutted of the original url.

I don't remember this being an issue when we rolled out the phpBB stuff (I think...).

Edit: Yup, just fired up a copy of the site circa my phpBB patch. Url quoting looks fine, so I guess I'm off the hook personally.

This is the result of me hitting the 'quote' button next to my original post. Notice that the url tag from the original post now points nowhere (whereas it originally pointed to Wikipedia).

This problem is completely unrelated to the thing I was talking about with braces in usernames, which is less of an actual concern.

I still am not able to replicate the issue. I tested quoting your post on Opera, Firefox and Chrome and it works fine.

maybe it's something to do with ur OS. Sometimes this happens to me when I use the computers in my university's pc room

dindon wrote:
a post with a URL, the url tags in the quoted text are gutted of the original url.

Testing. Like Mojko, not able to reproduce.

Looks like it was caused by one of my Firefox add-ons (Linkification). Disabling it seems to have fixed the problem.